Ticket #1409 (closed enhancement: invalid)

Opened 5 years ago

Last modified 4 years ago

sqlite installation

Reported by: zeph1r Assigned to: stevenstremciuc
Priority: normal Milestone: 0.6.3
Component: SGL - Install Severity: in progress
Keywords: Cc:

Description

diff against seagull-0.6.1.tar.gz downloaded from the seagull website

  • i modified the installer, and the 4 base modules sql/schema, to enable sqlite installation
  • i modified sturtup code to enable configuration replication (stupid hack to allow easily ip change to the machine where seagull is installed)
  • PEAR sqlite bugfix (on table aliasing)

Attachments

seagull.patch (3.5 kB) - added by zeph1r on 03/09/07 13:45:11.
installer changes
seagull.patch_sq.sql (37.9 kB) - added by zeph1r on 03/09/07 13:45:48.
sqlite installer schemas
seagull.patch_ip.replicate (2.3 kB) - added by zeph1r on 03/09/07 13:46:26.
configuration replication / bad HACK
seagull.patch_pear (0.9 kB) - added by zeph1r on 03/09/07 13:46:57.
PEAR/sqlite table aliasing BUGfix

Change History

03/09/07 13:45:11 changed by zeph1r

  • attachment seagull.patch added.

installer changes

03/09/07 13:45:48 changed by zeph1r

  • attachment seagull.patch_sq.sql added.

sqlite installer schemas

03/09/07 13:46:26 changed by zeph1r

  • attachment seagull.patch_ip.replicate added.

configuration replication / bad HACK

03/09/07 13:46:57 changed by zeph1r

  • attachment seagull.patch_pear added.

PEAR/sqlite table aliasing BUGfix

03/09/07 13:48:38 changed by zeph1r

please cite:

03/12/07 12:32:26 changed by demian

  • owner changed from somebody to zeph1r.
  • milestone set to 0.6.2.

Hi zeph1r

Thanks for the sqlite work, will be great to get this fully integrated in the core. A few things to keep in mind:

  • patches must always be done against the last svn bugfix branch, your is against quite old code
  • please follow coding standards, there are lots of docs in Trac for this
  • maybe for the shortname use 'lite', so you get filenames like data.default.lite.sql - your sq is a bit ambiguous
  • can you explain your changes to the postgres schemas?
  • please remove die() and debugging message from your patches
  • italian error message and your custom DEFAULTWEBPLAYER constants are not good candidates for core code
  • it's not practical to modify pear libs directly as per lib/pear/DB/sqlite.php, your changes will just get lost when we update, pls follow existing convention which is to override driver, see mysql_SGL, etc

Please reassign this ticket to me when you address the above. Thanks!

03/21/07 12:20:34 changed by demian

  • cc set to guido.serra@purotesto.it.

hi zeph1r - are you following this ticket?

03/21/07 12:54:12 changed by zeph1r

  • owner changed from zeph1r to demian.

now i do

sorry, my email account was deleted

use this: zeph@guidoserra.it

ok, i'll make new patches soon

03/21/07 12:54:49 changed by zeph1r

  • cc changed from guido.serra@purotesto.it to zeph@guidoserra.it.

03/22/07 07:11:19 changed by demian

  • owner changed from demian to stevenstremciuc.
  • severity changed from patch applied to need feedback.

heya Steve - would be great if you could fix this up, I think Guido has gone AWOL.

03/22/07 08:15:21 changed by zeph1r

sorry Demian,

here i'm :)

i had problems with email...

i'll try to make the patches as you want during next week

see ya

03/27/07 06:49:24 changed by demian

  • severity changed from need feedback to in progress.
  • milestone changed from 0.6.2 to 0.6.3.

hi zeph1r, steve - gonna move this to 0.6.3, we're short on time to get release out.

03/27/07 07:47:17 changed by zeph1r

no prob :)

01/23/08 07:38:16 changed by demian

  • cc deleted.
  • status changed from new to closed.
  • resolution set to invalid.

hmm, i don't have time to fix this ..