Ticket #1613 (assigned defect)

Opened 3 months ago

Last modified 1 month ago

Mutilple globalJavascriptFiles must be separated by ";"

Reported by: malber Assigned to: demian (accepted)
Priority: normal Milestone: 0.9.0 - refactoring
Component: SGL - Output Severity: open
Keywords: Cc:

Description

The tooltip and Trac docs say to separate multiple Javascript files with ';' but the makeJsOptimizerLink() breaks up the string based on a ,

If you want a Javascript file included on every page of your site, put it here (separate with ";" if several files) 

// javascript files, which always are loaded
        $this->addJavascriptFile(
            SGL_Config::get('site.globalJavascriptFiles')
                ? explode(',', SGL_Config::get('site.globalJavascriptFiles'))
                : array()
        );

Change History

04/15/08 06:18:09 changed by demian

  • status changed from new to assigned.

04/15/08 06:25:43 changed by demian

we'll correct the tooltip to reflect the code, then use ";" in 0.9 as it works better

06/17/08 17:50:33 changed by demian

  • summary changed from Mutilple globalJavascriptFiles separeted by ; or , ? to Mutilple globalJavascriptFiles must be separated by ";".
  • milestone changed from 0.6.5 to 0.9.0 - polishing.

done as per above, now sort it out in 0.9 :-)

06/25/08 19:17:55 changed by demian

  • milestone changed from 0.9.1 - polishing to 0.9.0 - refactoring.