Ticket #1745 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

Patch to replace all remaining split calls with preg_split

Reported by: openhaus Assigned to: demian
Priority: normal Milestone: 1.0
Component: SGL Severity: open
Keywords: Patch, split, Cc:

Description

Patch to replace all remaining split calls with preg_split as discussed in http://groups.google.de/group/seagull_general/browse_thread/thread/aac42d9273379d2c

Attachments

split_removal.patch (6.6 kB) - added by openhaus on 02/24/10 07:47:52.
Patch to replace split function
split_removal_trunk.patch (2.6 kB) - added by openhaus on 02/24/10 09:39:27.
Patch to replace split function

Change History

02/24/10 07:47:52 changed by openhaus

  • attachment split_removal.patch added.

Patch to replace split function

02/24/10 08:10:05 changed by demian

thanks dude, but is this again bugfix? It needs to be against trunk. I removed all files/modules that don't exist, and still got fails: 

demians-mbp:trunk demian$ patch -p0 --dry-run < split_removal.patch 
patching file lib/SGL/Config.php
Hunk #1 FAILED at 149.
Hunk #2 FAILED at 455.
2 out of 2 hunks FAILED -- saving rejects to file lib/SGL/Config.php.rej
patching file modules/navigation/classes/NavigationDAO.php
Hunk #1 succeeded at 218 (offset 1 line).
Hunk #2 succeeded at 546 (offset 1 line).
Hunk #3 FAILED at 627.
1 out of 3 hunks FAILED -- saving rejects to file modules/navigation/classes/NavigationDAO.php.rej
patching file modules/navigation/classes/SimpleDriver.php
patching file modules/user/classes/RoleMgr.php

02/24/10 09:32:54 changed by openhaus

Yes, that patch was against bugfix. Apply it there.

02/24/10 09:39:27 changed by openhaus

  • attachment split_removal_trunk.patch added.

Patch to replace split function

02/24/10 09:40:20 changed by openhaus

There you go. The patch file for trunk. Cheers.

02/24/10 13:35:05 changed by demian

  • status changed from new to closed.
  • resolution set to fixed.

nice one dude, thanks.